Discussion:
[pcp] pcp updates: more libpcp locking evolution and qa (mostly for Mac OS X)
Ken McDonell
2017-08-02 01:55:59 UTC
Permalink
Changes committed to https://github.com/kmcdonell/pcp master

Ken McDonell (25):
src/libpcp/src/check-statics: local mutex will always be present
src/libpcp: add AF_lock as local mutex for AF.c
src/libpcp: fix AF_lock initialization
src/libpcp: add secureserver_lock as local mutex for secureserver.c
src/libpcp: add connect_lock as local mutex for connect.c
src/libpcp/doc/mk.graph: track recent local mutex additions
src/libpcp/src/secureserver.c: remove nested locking
src/pmlogconf/tools/pcp-summary: hinv.ntape not used in pcp-summary command
qa/297: filter change - fd for context is not deterministic
qa/389: rework daemon stopping and starting
qa/451 & 998: abort may not trigger a core dump
qa/827: for non-linux platforms _notrun if pmlogrewrite files not installed
configure.ac: change logic for fmt_int64 determination
1051: remade .out for Mac OS X
qa/1084: exercises linux PMDA, _notrun for non-linux platforms
qa/110: more diagnostics ... fifo tests are flakey on some platforms
qa/1100: _notrun if Python OrderedDict module not found
qa/833: PMDA domain number for kernel.* and hinv.* is not constant
qa/895: Mac OS X changes
qa/910: exercises linux PMDA, _notrun for non-linux platforms
qa/934: Mac OS X changes
qa/953: Mac OS X changes
qa/956: Mac OS X changes
qa/admin/check-vm: add perl-interpreter to list of things to check
src/pmdas/darwin: indom help text and cosmetic comment fix

configure | 16 --
configure.ac | 16 --
qa/1051.out.darwin | 2
qa/1084 | 10 +
qa/110 | 4
qa/1100 | 12 +
qa/297 | 3
qa/297.out | 2
qa/389 | 9 -
qa/389.out | 1
qa/451 | 5
qa/827 | 16 ++
qa/833 | 2
qa/833.out | 80 ++++++------
qa/895 | 31 ++++
qa/895.out | 2
qa/910 | 16 ++
qa/934 | 13 ++
qa/934.out | 10 -
qa/953 | 15 +-
qa/953.out | 240 +++++++++++++++++++-------------------
qa/956 | 6
qa/998 | 5
qa/admin/check-vm | 3
src/libpcp/doc/libpcp-locking.odt |binary
src/libpcp/doc/mk.cgraph | 9 +
src/libpcp/src/AF.c | 31 ++++
src/libpcp/src/check-statics | 45 +++----
src/libpcp/src/connect.c | 39 +++++-
src/libpcp/src/internal.h | 6
src/libpcp/src/lock.c | 9 +
src/libpcp/src/pmns.c | 12 -
src/libpcp/src/secureserver.c | 47 +++++--
src/pmdas/darwin/help | 8 +
src/pmdas/darwin/pmda.c | 2
src/pmlogconf/tools/pcp-summary | 1
36 files changed, 463 insertions(+), 265 deletions(-)

Details ...

commit 66b774201193ca0fae395c3dd09e457db5f1b80e
Author: Ken McDonell <***@internode.on.net>
Date: Wed Aug 2 11:54:20 2017 +1000

src/pmdas/darwin: indom help text and cosmetic comment fix

commit bc5e48b817f4130f8aac9ef6a8d01b8881223e69
Author: Ken McDonell <***@internode.on.net>
Date: Wed Aug 2 11:53:23 2017 +1000

qa/admin/check-vm: add perl-interpreter to list of things to check

commit da07528eff0865cb51d1a42475ebe8b364d6e7cf
Author: Ken McDonell <***@internode.on.net>
Date: Wed Aug 2 11:52:35 2017 +1000

qa/956: Mac OS X changes

ps(1) output for defunct processes is different

commit f93c824cd08b960a17302ada5b11b7b04a562644
Author: Ken McDonell <***@internode.on.net>
Date: Wed Aug 2 11:51:28 2017 +1000

qa/953: Mac OS X changes

errno values (and associated text) are different ... just for the
hell of it!

commit 84ec05c6726670cbd82723567c62e9965801b569
Author: Ken McDonell <***@internode.on.net>
Date: Wed Aug 2 11:50:04 2017 +1000

qa/934: Mac OS X changes

Changes in output for ... ls(1), chown(1) and mkdir(1).

commit c703fb6d31f891c71ee854b92f092d12a9e069d4
Author: Ken McDonell <***@internode.on.net>
Date: Wed Aug 2 11:49:05 2017 +1000

qa/910: exercises linux PMDA, _notrun for non-linux platforms

commit 4996120c61faec3f5f4ed42e430b878835951ac6
Author: Ken McDonell <***@internode.on.net>
Date: Wed Aug 2 11:46:58 2017 +1000

qa/895: Mac OS X changes

1. remove some metrics that are not available on some platforms from
the pmlogger config
2. increase the logging delta from 10msec to 20msec to pander to
older and slower platforms

commit d281667658bbf08f933019ea64c8cf19bc57c527
Author: Ken McDonell <***@internode.on.net>
Date: Wed Aug 2 10:37:48 2017 +1000

qa/833: PMDA domain number for kernel.* and hinv.* is not constant

commit 981d37f9cae7b18f628eeffda234e36f6647ff3b
Author: Ken McDonell <***@internode.on.net>
Date: Wed Aug 2 10:36:47 2017 +1000

qa/1100: _notrun if Python OrderedDict module not found

commit 9e570ba574c70e4dcda397e46c2ef90206cf3abf
Author: Ken McDonell <***@internode.on.net>
Date: Wed Aug 2 10:36:05 2017 +1000

qa/110: more diagnostics ... fifo tests are flakey on some platforms

commit 88103e098e018ba7d6fc3e440c957d84a7f87775
Author: Ken McDonell <***@internode.on.net>
Date: Wed Aug 2 10:35:21 2017 +1000

qa/1084: exercises linux PMDA, _notrun for non-linux platforms

commit ce5ba9035f455ae281c6372a0799d5fa86072676
Author: Ken McDonell <***@internode.on.net>
Date: Wed Aug 2 10:34:17 2017 +1000

1051: remade .out for Mac OS X

The pmcd PMDA has moved on since this was first checked in.

commit 41b991a683a9f73c2ad413a29277747c31d01458
Author: Ken McDonell <***@internode.on.net>
Date: Wed Aug 2 10:31:06 2017 +1000

configure.ac: change logic for fmt_int64 determination

Previous logic was flawed when compiler issued warning and then
silently cast the operand, meaning both tests would have worked
and the result depended only on the ordering of the if-else.

Magically this has worked most places, but failed on my 32-bit
Mac OS X platform.

commit 0a49e83f7f64ba0f881472959a5c7de71689e427
Author: Ken McDonell <***@internode.on.net>
Date: Sat Jul 29 17:37:54 2017 +1000

qa/827: for non-linux platforms _notrun if pmlogrewrite files not installed

This one sort of depends on the Linux PMDA being installed (which
brings along the pmlogrewrite rules this test is using).

commit 3879fcf3f0d5a83a3710b10fe32111041d873897
Author: Ken McDonell <***@internode.on.net>
Date: Sat Jul 29 17:36:55 2017 +1000

qa/451 & 998: abort may not trigger a core dump

Tweak filter.

commit 1f2ee7047b3ae37acd66e7d7c6d8c40da08697aa
Author: Ken McDonell <***@internode.on.net>
Date: Sat Jul 29 17:34:26 2017 +1000

qa/389: rework daemon stopping and starting

1. don't (maybe) restart pmlogger
2. take better control of pmcd stop, pause, restart to avoid race
with pmlogger disconnect and reconnect
3. handle wc(1) white space differences on Mac OS X

commit 3032e57afa13d7d732131174bf0912b5cf98dfc1
Author: Ken McDonell <***@internode.on.net>
Date: Sat Jul 29 17:31:25 2017 +1000

qa/297: filter change - fd for context is not deterministic

Was failing on Mac OS X.

commit bcd6605096fa7ada5da2b913b291501c8aa304c5
Author: Ken McDonell <***@internode.on.net>
Date: Sat Jul 29 14:11:57 2017 +1000

src/pmlogconf/tools/pcp-summary: hinv.ntape not used in pcp-summary command

So, don't need it in this pmlogconf file.

Was causing qa/364 failure on Mac OS X where hinv.ntape is not in
the PMNS.

commit c682ce2280823f08012ad9d6f9beeb9ff3f8a023
Author: Ken McDonell <***@internode.on.net>
Date: Fri Jul 28 06:52:51 2017 +1000

src/libpcp/src/secureserver.c: remove nested locking

Uncovered when moving from __pmLock_libpcp (recursive) to
secureserver_lock (not recursive).

commit 3d5ce1602d4f28c7c4958efca21159b771cbda6d
Author: Ken McDonell <***@internode.on.net>
Date: Fri Jul 28 05:36:17 2017 +1000

src/libpcp/doc/mk.graph: track recent local mutex additions

commit 1e89f9e7b8fb4c96d482cb38e9aa3fd49e10167d
Author: Ken McDonell <***@internode.on.net>
Date: Fri Jul 28 05:34:39 2017 +1000

src/libpcp: add connect_lock as local mutex for connect.c

Another place where the "big libpcp lock" is not needed.

commit 0b03fc8facb10190d1c44e9c121d758e8c6f1f8d
Author: Ken McDonell <***@internode.on.net>
Date: Thu Jul 27 17:34:44 2017 +1000

src/libpcp: add secureserver_lock as local mutex for secureserver.c

The "big libpcp lock" has been placed on the WWF endangered species list.

commit 734e7fc74b84536717279df9319532704518d96b
Author: Ken McDonell <***@internode.on.net>
Date: Thu Jul 27 15:19:11 2017 +1000

src/libpcp: fix AF_lock initialization

commit 7a422e252685a9492e4f4d3c7aad8a83d8e87575
Author: Ken McDonell <***@internode.on.net>
Date: Thu Jul 27 09:56:04 2017 +1000

src/libpcp: add AF_lock as local mutex for AF.c

One more place where the "big libpcp lock" is not needed.

commit 11e1027acf806f8c6cebf0cbf1f2b8ece9cf5fe0
Author: Ken McDonell <***@internode.on.net>
Date: Thu Jul 27 09:04:04 2017 +1000

src/libpcp/src/check-statics: local mutex will always be present

-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links:

You receive all messages sent to this group.

View/Reply Online (#16316): https://groups.io/g/pcp/message/16316
View All Messages In Topic (1): https://groups.io/g/pcp/topic/5716996
Mute This Topic: https://groups.io/mt/5716996/174549
New Topic: https://groups.io/g/pcp/post
-=-=-
pcp mailing list
***@groups.io
https://groups.io/g/pcp/messages
-=-=-
Change Your Subscription: https://groups.io/g/pcp/editsub/174549
Group Home: https://groups.io/g/pcp
Contact Group Owner: pcp+***@groups.io
Terms of Service: https://groups.io/static/tos
Unsubscribe: https://groups.io/g/pcp/leave/354206/1187008340/xyzzy
-=-=-=-=-=-=-=-=-=-=-=-

Loading...