[pcp] Updates to Github #github #rust

[[e-mail] Integration]

[hornet] New branch indom ( https://github.com/performancecopilot/hornet/tree/indom ) was created by saurvs.



---

1 New Commit:

[hornet:indom] By Saurav Sachidanand <***@gmail.com>:
72e32205dbc8 ( https://github.com/performancecopilot/hornet/commit/72e32205dbc87ce7859a33248e2af39732583786 ) : Make indoms explicit

Modified: src/client/metric.rs ( https://github.com/performancecopilot/hornet/blob/indom/src/client/metric.rs )
Modified: src/client/mod.rs ( https://github.com/performancecopilot/hornet/blob/indom/src/client/mod.rs )

[[e-mail] Integration]

1 New Commit:

[hornet:indom] By Saurav Sachidanand <***@gmail.com>:
40823ae83b83 ( https://github.com/performancecopilot/hornet/commit/40823ae83b830c35e7f2bfeceb32cb42343fbbb2 ) : Add string cache

Modified: src/client/mod.rs ( https://github.com/performancecopilot/hornet/blob/indom/src/client/mod.rs )



---

[performancecopilot/hornet] Pull request updated by saurvs ( https://github.com/saurvs ) :

#23 Indom ( https://github.com/performancecopilot/hornet/pull/23 )

This is a slightly more complex API which makes Indom explicit to the user. As opposed to https://github.com/performancecopilot/hornet/pull/20 ( https://github.com/performancecopilot/hornet/pull/20 ) , this API allows setting of the Indom's short and long text, and also allows sharing indoms between instance metrics.

I've also added an Indom cache while writing the MMV to write only one indom block per unique Indom .



---

[performancecopilot/hornet] Pull request updated by saurvs ( https://github.com/saurvs ) :

#23 Indom ( https://github.com/performancecopilot/hornet/pull/23 )

This is a slightly more complex API which makes Indom explicit to the user. As opposed to https://github.com/performancecopilot/hornet/pull/20 ( https://github.com/performancecopilot/hornet/pull/20 ) , this API allows setting of the Indom's short and long text, and also allows sharing indoms between instance metrics.

I've also added an Indom cache while writing the MMV to write only one indom block per unique Indom .



---

[performancecopilot/hornet] Pull request updated by saurvs ( https://github.com/saurvs ) :

#23 Indom ( https://github.com/performancecopilot/hornet/pull/23 )

This is a slightly more complex API which makes Indom explicit to the user. As opposed to https://github.com/performancecopilot/hornet/pull/20 ( https://github.com/performancecopilot/hornet/pull/20 ) , this API allows setting of the Indom's short and long text, and also allows sharing indoms between instance metrics.

I've also added an Indom cache while writing the MMV to write only one indom block per unique Indom , and a string cache for constant strings as well.



---

[performancecopilot/hornet] Pull request updated by saurvs ( https://github.com/saurvs ) :

#23 Implement instance metrics with explicit indoms ( https://github.com/performancecopilot/hornet/pull/23 )

This is a slightly more complex API which makes Indom explicit to the user. As opposed to https://github.com/performancecopilot/hornet/pull/20 ( https://github.com/performancecopilot/hornet/pull/20 ) , this API allows setting of the Indom's short and long text, and also allows sharing indoms between instance metrics.

I've also added an Indom cache while writing the MMV to write only one indom block per unique Indom , and a string cache for constant strings as well.

[[e-mail] Integration]

1 New Commit:

[hornet:indom] By Saurav Sachidanand <***@gmail.com>:
f0e2f52c7eda ( https://github.com/performancecopilot/hornet/commit/f0e2f52c7eda2cfe8e20215b86350714ea3417e6 ) : Write cargo doc comments

Modified: src/client/metric.rs ( https://github.com/performancecopilot/hornet/blob/indom/src/client/metric.rs )



---

[performancecopilot/hornet] Pull request updated by saurvs ( https://github.com/saurvs ) :

#23 Implement instance metrics with explicit indoms ( https://github.com/performancecopilot/hornet/pull/23 )

This is a slightly more complex API which makes Indom explicit to the user. As opposed to https://github.com/performancecopilot/hornet/pull/20 ( https://github.com/performancecopilot/hornet/pull/20 ) , this API allows setting of the Indom's short and long text, and also allows sharing indoms between instance metrics.

I've also added an Indom cache while writing the MMV to write only one indom block per unique Indom , and a string cache for constant strings as well.

[[e-mail] Integration]

1 New Commit:

[hornet:indom] By Saurav Sachidanand <***@gmail.com>:
1f0b748b7a78 ( https://github.com/performancecopilot/hornet/commit/1f0b748b7a7847974b9967f930095ae091382479 ) : Suffix instance to metric names

Modified: src/client/metric.rs ( https://github.com/performancecopilot/hornet/blob/indom/src/client/metric.rs )



---

[performancecopilot/hornet] Pull request updated by saurvs ( https://github.com/saurvs ) :

#23 Implement instance metrics with explicit indoms ( https://github.com/performancecopilot/hornet/pull/23 )

This is a slightly more complex API which makes Indom explicit to the user. As opposed to https://github.com/performancecopilot/hornet/pull/20 ( https://github.com/performancecopilot/hornet/pull/20 ) , this API allows setting of the Indom's short and long text, and also allows sharing indoms between instance metrics.

I've also added an Indom cache while writing the MMV to write only one indom block per unique Indom , and a string cache for constant strings as well.



---

[performancecopilot/hornet] Pull request updated by saurvs ( https://github.com/saurvs ) :

#23 Implement instance metrics with explicit indoms ( https://github.com/performancecopilot/hornet/pull/23 )

This is a slightly more complex API which makes Indom explicit to the user. As opposed to https://github.com/performancecopilot/hornet/pull/20 ( https://github.com/performancecopilot/hornet/pull/20 ) , this API allows setting of the Indom's short and long text, and also allows sharing indoms between instance metrics.

I've also added an Indom cache while writing the MMV to write only one indom block per unique Indom , and a string cache for constant strings as well.



---

2 New Commits:

[hornet:indom] By Saurav Sachidanand <***@gmail.com>:
690335f80c71 ( https://github.com/performancecopilot/hornet/commit/690335f80c7142d037e63d7267cc95e2501b170d ) : Update readme (#19) * Update readme * Add details on monitoring mapped metrics

Modified: README.md ( https://github.com/performancecopilot/hornet/blob/indom/README.md )

[hornet:indom] By Saurav Sachidanand <***@gmail.com>:
3f3d5174594e ( https://github.com/performancecopilot/hornet/commit/3f3d5174594e22be3038983901df42d8d1df93ff ) : Merge branch 'master' into indom

Modified: README.md ( https://github.com/performancecopilot/hornet/blob/indom/README.md )



---

[hornet:master] New Comment on Pull Request #23 Implement instance metrics with explicit indoms ( https://github.com/performancecopilot/hornet/pull/23 )
By saurvs ( https://github.com/saurvs ) :

@suyash I think we need to suffix instance strings to the metric name otherwise we'd get more many metrics with the same name.

[[e-mail] Integration]

[hornet:master] New Comment on Pull Request #23 Implement instance metrics with explicit indoms ( https://github.com/performancecopilot/hornet/pull/23 )
By suyash ( https://github.com/suyash ) :

@saurvs TBH I did like the idea of using the existing metrics implementation to write instances, but now I realize how that might have been confusing



---

[hornet:master] New Comment on Pull Request #23 Implement instance metrics with explicit indoms ( https://github.com/performancecopilot/hornet/pull/23 )
By suyash ( https://github.com/suyash ) :

Also just noticed a couple of things

* the lockfile is ignored by git. That is not ok, since the purpose is to have reproducible builds
* the cluster id is zero in the dump, which should be something random

Also close #20 if you're going to work in this PR



---

[hornet:master] New Comment on Pull Request #20 Implement MMVv1 instance metrics ( https://github.com/performancecopilot/hornet/pull/20 )
By saurvs ( https://github.com/saurvs ) :

Closing in favour of https://github.com/performancecopilot/hornet/pull/23 ( https://github.com/performancecopilot/hornet/pull/23 )



---

[performancecopilot/hornet] Pull request closed by saurvs ( https://github.com/saurvs ) :

#20 Implement MMVv1 instance metrics ( https://github.com/performancecopilot/hornet/pull/20 )

Apart from implementing instance metrics, this also includes some cleanup/refactoring of singleton metric writing in order to improve code reuse.



---

[hornet:master] New Comment on Pull Request #23 Implement instance metrics with explicit indoms ( https://github.com/performancecopilot/hornet/pull/23 )
By saurvs ( https://github.com/saurvs ) :

I think @natoscott suggested the cluster ID by default should be zero in the MMV header PR. I think a hash of the name would make more sense.

[[e-mail] Integration]

[performancecopilot/hornet] Pull request updated by saurvs ( https://github.com/saurvs ) :

#23 Implement instance metrics with explicit indoms ( https://github.com/performancecopilot/hornet/pull/23 )

This is a slightly more complex API which makes Indom explicit to the user. As opposed to https://github.com/performancecopilot/hornet/pull/20 ( https://github.com/performancecopilot/hornet/pull/20 ) , this API allows setting of the Indom's short and long text, and also allows sharing indoms between instance metrics.

I've also added an Indom cache while writing the MMV to write only one indom block per unique Indom , and a string cache for constant strings as well.



---

2 New Commits:

[hornet:indom] By Saurav Sachidanand <***@gmail.com>:
79be8afff848 ( https://github.com/performancecopilot/hornet/commit/79be8afff848c148963de59874df924909b2b586 ) : Change instance implementation

Modified: examples/acme.rs ( https://github.com/performancecopilot/hornet/blob/indom/examples/acme.rs )
Modified: examples/physical.rs ( https://github.com/performancecopilot/hornet/blob/indom/examples/physical.rs )
Modified: src/client/metric.rs ( https://github.com/performancecopilot/hornet/blob/indom/src/client/metric.rs )
Modified: src/client/mod.rs ( https://github.com/performancecopilot/hornet/blob/indom/src/client/mod.rs )

[hornet:indom] By Saurav Sachidanand <***@gmail.com>:
51b61d0cb234 ( https://github.com/performancecopilot/hornet/commit/51b61d0cb23400020320ca2b22194d5b0ab0a00b ) : Merge branch 'indom' of https://github.com/performancecopilot/hornet into indom

Modified: README.md ( https://github.com/performancecopilot/hornet/blob/indom/README.md )



---

[hornet:master] New Comment on Pull Request #23 Implement instance metrics with explicit indoms ( https://github.com/performancecopilot/hornet/pull/23 )
By saurvs ( https://github.com/saurvs ) :

@suyash I've made the necessary changes, but the registration interface is very awkward, and probably only be fixed by going back to the export(m1, m2, ...) API. We can do that after implementing the higher-level metrics though.



---

[hornet:master] New Comment on Pull Request #23 Implement instance metrics with explicit indoms ( https://github.com/performancecopilot/hornet/pull/23 )
By saurvs ( https://github.com/saurvs ) :

@suyash I've made the necessary changes, but the registration interface is very awkward, and can probably only be fixed by going back to the export(m1, m2, ...) API. We can do that after implementing the higher-level metrics though.

[[e-mail] Integration]

1 New Commit:

[hornet:indom] By Saurav Sachidanand <***@gmail.com>:
f58c623991f7 ( https://github.com/performancecopilot/hornet/commit/f58c623991f746a6a460714cf84a5bfef6138d6f ) : Merge branch 'indom' of https://github.com/performancecopilot/hornet into indom

Modified: README.md ( https://github.com/performancecopilot/hornet/blob/indom/README.md )
Modified: src/client/metric.rs ( https://github.com/performancecopilot/hornet/blob/indom/src/client/metric.rs )



---

[performancecopilot/hornet] Pull request updated by saurvs ( https://github.com/saurvs ) :

#23 Implement instance metrics with explicit indoms ( https://github.com/performancecopilot/hornet/pull/23 )

This is a slightly more complex API which makes Indom explicit to the user. As opposed to https://github.com/performancecopilot/hornet/pull/20 ( https://github.com/performancecopilot/hornet/pull/20 ) , this API allows setting of the Indom's short and long text, and also allows sharing indoms between instance metrics.

I've also added an Indom cache while writing the MMV to write only one indom block per unique Indom , and a string cache for constant strings as well.



---

1 New Commit:

[hornet:indom] By Saurav Sachidanand <***@gmail.com>:
c065142d03c4 ( https://github.com/performancecopilot/hornet/commit/c065142d03c446832d8fdf07bd784d96a7b8eed9 ) : Merge branch 'indom' of https://github.com/performancecopilot/hornet into indom

Modified: README.md ( https://github.com/performancecopilot/hornet/blob/indom/README.md )
Modified: src/client/metric.rs ( https://github.com/performancecopilot/hornet/blob/indom/src/client/metric.rs )



---

[performancecopilot/hornet] Pull request updated by saurvs ( https://github.com/saurvs ) :

#23 Implement instance metrics with explicit indoms ( https://github.com/performancecopilot/hornet/pull/23 )

This is a slightly more complex API which makes Indom explicit to the user. As opposed to https://github.com/performancecopilot/hornet/pull/20 ( https://github.com/performancecopilot/hornet/pull/20 ) , this API allows setting of the Indom's short and long text, and also allows sharing indoms between instance metrics.

I've also added an Indom cache while writing the MMV to write only one indom block per unique Indom , and a string cache for constant strings as well.



---

1 New Commit:

[hornet:indom] By Saurav Sachidanand <***@gmail.com>:
0881df9f7890 ( https://github.com/performancecopilot/hornet/commit/0881df9f7890eb11971970a597ae87d5c2f1cff2 ) : Merge branch 'indom' of https://github.com/performancecopilot/hornet into indom

Modified: README.md ( https://github.com/performancecopilot/hornet/blob/indom/README.md )
Modified: src/client/metric.rs ( https://github.com/performancecopilot/hornet/blob/indom/src/client/metric.rs )



---

[performancecopilot/hornet] Pull request updated by saurvs ( https://github.com/saurvs ) :

#23 Implement instance metrics with explicit indoms ( https://github.com/performancecopilot/hornet/pull/23 )

This is a slightly more complex API which makes Indom explicit to the user. As opposed to https://github.com/performancecopilot/hornet/pull/20 ( https://github.com/performancecopilot/hornet/pull/20 ) , this API allows setting of the Indom's short and long text, and also allows sharing indoms between instance metrics.

I've also added an Indom cache while writing the MMV to write only one indom block per unique Indom , and a string cache for constant strings as well.



---

1 New Commit:

[hornet:indom] By Saurav Sachidanand <***@gmail.com>:
5f27c4c9a194 ( https://github.com/performancecopilot/hornet/commit/5f27c4c9a19439581d0f914bf0fad5ab634f56f4 ) : Merge branch 'indom' of https://github.com/performancecopilot/hornet into indom

Modified: README.md ( https://github.com/performancecopilot/hornet/blob/indom/README.md )
Modified: src/client/metric.rs ( https://github.com/performancecopilot/hornet/blob/indom/src/client/metric.rs )



---

[performancecopilot/hornet] Pull request updated by saurvs ( https://github.com/saurvs ) :

#23 Implement instance metrics with explicit indoms ( https://github.com/performancecopilot/hornet/pull/23 )

This is a slightly more complex API which makes Indom explicit to the user. As opposed to https://github.com/performancecopilot/hornet/pull/20 ( https://github.com/performancecopilot/hornet/pull/20 ) , this API allows setting of the Indom's short and long text, and also allows sharing indoms between instance metrics.

I've also added an Indom cache while writing the MMV to write only one indom block per unique Indom , and a string cache for constant strings as well.

[[e-mail] Integration]

1 New Commit:

[hornet:indom] By Saurav Sachidanand <***@gmail.com>:
e54faf415055 ( https://github.com/performancecopilot/hornet/commit/e54faf41505513c582576e4adfa10c5463ccfadb ) : Merge branch 'indom' of https://github.com/performancecopilot/hornet into indom

Modified: README.md ( https://github.com/performancecopilot/hornet/blob/indom/README.md )
Modified: src/client/metric.rs ( https://github.com/performancecopilot/hornet/blob/indom/src/client/metric.rs )



---

[performancecopilot/hornet] Pull request updated by saurvs ( https://github.com/saurvs ) :

#23 Implement instance metrics with explicit indoms ( https://github.com/performancecopilot/hornet/pull/23 )

This is a slightly more complex API which makes Indom explicit to the user. As opposed to https://github.com/performancecopilot/hornet/pull/20 ( https://github.com/performancecopilot/hornet/pull/20 ) , this API allows setting of the Indom's short and long text, and also allows sharing indoms between instance metrics.

I've also added an Indom cache while writing the MMV to write only one indom block per unique Indom , and a string cache for constant strings as well.



---

1 New Commit:

[hornet:indom] By Saurav Sachidanand <***@gmail.com>:
f7e6e5f6e985 ( https://github.com/performancecopilot/hornet/commit/f7e6e5f6e985136ad60c986d469aab09aa935d9a ) : Merge branch 'indom' of https://github.com/performancecopilot/hornet into indom

Modified: README.md ( https://github.com/performancecopilot/hornet/blob/indom/README.md )
Modified: src/client/metric.rs ( https://github.com/performancecopilot/hornet/blob/indom/src/client/metric.rs )



---

[performancecopilot/hornet] Pull request updated by saurvs ( https://github.com/saurvs ) :

#23 Implement instance metrics with explicit indoms ( https://github.com/performancecopilot/hornet/pull/23 )

This is a slightly more complex API which makes Indom explicit to the user. As opposed to https://github.com/performancecopilot/hornet/pull/20 ( https://github.com/performancecopilot/hornet/pull/20 ) , this API allows setting of the Indom's short and long text, and also allows sharing indoms between instance metrics.

I've also added an Indom cache while writing the MMV to write only one indom block per unique Indom , and a string cache for constant strings as well.

[[e-mail] Integration]

1 New Commit:

[hornet:indom] By Saurav Sachidanand <***@gmail.com>:
3a783c3c8c88 ( https://github.com/performancecopilot/hornet/commit/3a783c3c8c88a4448bb0b6a2b073f77c83558b60 ) : Fix mmv_size bug

Modified: src/client/mod.rs ( https://github.com/performancecopilot/hornet/blob/indom/src/client/mod.rs )
Modified: src/lib.rs ( https://github.com/performancecopilot/hornet/blob/indom/src/lib.rs )



---

[performancecopilot/hornet] Pull request updated by saurvs ( https://github.com/saurvs ) :

#23 Implement instance metrics with explicit indoms ( https://github.com/performancecopilot/hornet/pull/23 )

This is a slightly more complex API which makes Indom explicit to the user. As opposed to https://github.com/performancecopilot/hornet/pull/20 ( https://github.com/performancecopilot/hornet/pull/20 ) , this API allows setting of the Indom's short and long text, and also allows sharing indoms between instance metrics.

I've also added an Indom cache while writing the MMV to write only one indom block per unique Indom , and a string cache for constant strings as well.

[[e-mail] Integration]

1 New Commit:

[hornet:indom] By Saurav Sachidanand <***@gmail.com>:
91454da5f5b1 ( https://github.com/performancecopilot/hornet/commit/91454da5f5b153531f6ab11eede25332a01fecd3 ) : Add string length checks for Indom Also uncomment some code

Modified: examples/acme.rs ( https://github.com/performancecopilot/hornet/blob/indom/examples/acme.rs )
Modified: src/client/metric.rs ( https://github.com/performancecopilot/hornet/blob/indom/src/client/metric.rs )



---

[performancecopilot/hornet] Pull request updated by saurvs ( https://github.com/saurvs ) :

#23 Implement instance metrics with explicit indoms ( https://github.com/performancecopilot/hornet/pull/23 )

This is a slightly more complex API which makes Indom explicit to the user. As opposed to https://github.com/performancecopilot/hornet/pull/20 ( https://github.com/performancecopilot/hornet/pull/20 ) , this API allows setting of the Indom's short and long text, and also allows sharing indoms between instance metrics.

I've also added an Indom cache while writing the MMV to write only one indom block per unique Indom , and a string cache for constant strings as well.

[[e-mail] Integration]

[hornet] New branch mmvdump ( https://github.com/performancecopilot/hornet/tree/mmvdump ) was created by saurvs.



---

1 New Commit:

[hornet:mmvdump] By Saurav Sachidanand <***@gmail.com>:
0cc387470a1d ( https://github.com/performancecopilot/hornet/commit/0cc387470a1dc74f93651326d6e6272d266829bf ) : Implement low-level MMV API

Modified: src/lib.rs ( https://github.com/performancecopilot/hornet/blob/mmvdump/src/lib.rs )



---

1 New Commit:

[hornet:mmvdump] By Saurav Sachidanand <***@gmail.com>:
d791c6a6dd15 ( https://github.com/performancecopilot/hornet/commit/d791c6a6dd15a1b6f084d1d78660c420d4bd2e57 ) : Implement low-level MMV API

Added: src/mmv.rs ( https://github.com/performancecopilot/hornet/blob/mmvdump/src/mmv.rs )
Modified: src/lib.rs ( https://github.com/performancecopilot/hornet/blob/mmvdump/src/lib.rs )



---

[performancecopilot/hornet] Pull request opened by saurvs ( https://github.com/saurvs ) :

#24 Implement low-level MMV API ( https://github.com/performancecopilot/hornet/pull/24 )

This will also be useful for implementing the mmvdump command and for testing MMV writing.



---

2 New Commits:

[hornet:mmvdump] By Saurav Sachidanand <***@gmail.com>:
690335f80c71 ( https://github.com/performancecopilot/hornet/commit/690335f80c7142d037e63d7267cc95e2501b170d ) : Update readme (#19) * Update readme * Add details on monitoring mapped metrics

Modified: README.md ( https://github.com/performancecopilot/hornet/blob/mmvdump/README.md )

[hornet:mmvdump] By Saurav Sachidanand <***@gmail.com>:
168ba01caf1c ( https://github.com/performancecopilot/hornet/commit/168ba01caf1c427a1c50a1c525e3443e5c71c34a ) : Merge branch 'master' into mmvdump

Modified: README.md ( https://github.com/performancecopilot/hornet/blob/mmvdump/README.md )



---

[performancecopilot/hornet] Pull request updated by saurvs ( https://github.com/saurvs ) :

#24 Implement low-level MMV API ( https://github.com/performancecopilot/hornet/pull/24 )

This will also be useful for implementing the mmvdump command and for testing MMV writing.



---

[performancecopilot/hornet] Pull request updated by saurvs ( https://github.com/saurvs ) :

#24 Implement low-level MMV API ( https://github.com/performancecopilot/hornet/pull/24 )

This will also be useful for implementing the mmvdump command and for testing MMV writing.

[[e-mail] Integration]

[hornet:master] New Comment on Pull Request #24 Implement low-level MMV API ( https://github.com/performancecopilot/hornet/pull/24 )
By suyash ( https://github.com/suyash ) :

I actually considered this for speed, but didn't see a utility for this, since you cannot make things like indom offsets public fields. Why not implement mmvdump directly?



---

[hornet:master] New Comment on Pull Request #24 Implement low-level MMV API ( https://github.com/performancecopilot/hornet/pull/24 )
By suyash ( https://github.com/suyash ) :

I actually considered this for speed, but didn't see a utility for this, since you cannot make things like indom offsets public fields. Why not implement mmvdump directly as a binary?



---

[hornet:master] New Comment on Pull Request #24 Implement low-level MMV API ( https://github.com/performancecopilot/hornet/pull/24 )
By suyash ( https://github.com/suyash ) :

Ideally we should be able to do cargo install mmvdump to get the rust mmvdump binary



---

[hornet:master] New Comment on Pull Request #23 Implement instance metrics with explicit indoms ( https://github.com/performancecopilot/hornet/pull/23 )
By suyash ( https://github.com/suyash ) :

This looks good to me, waiting for @cuviper for a general code review, but rest looks good

[[e-mail] Integration]

[hornet:master] New Comment on Pull Request #24 Implement low-level MMV API ( https://github.com/performancecopilot/hornet/pull/24 )
By suyash ( https://github.com/suyash ) :

Oh, sorry that slipped my mind, so you'll add client tests separately?



---

[hornet:master] New Comment on Pull Request #24 Implement low-level MMV API ( https://github.com/performancecopilot/hornet/pull/24 )
By suyash ( https://github.com/suyash ) :

Let's hold off on cargo install for now, if you'll add client tests separately then this looks good to me



---

[hornet:master] New Comment on Pull Request #24 Implement low-level MMV API ( https://github.com/performancecopilot/hornet/pull/24 )
By suyash ( https://github.com/suyash ) :

Also, test this against fixed ios, some are at https://github.com/performancecopilot/speed/tree/master/mmvdump/testdata ( https://github.com/performancecopilot/speed/tree/master/mmvdump/testdata )



---

[hornet:master] New Comment on Pull Request #24 Implement low-level MMV API ( https://github.com/performancecopilot/hornet/pull/24 )
By suyash ( https://github.com/suyash ) :

Also, test this against fixed cases, some are at https://github.com/performancecopilot/speed/tree/master/mmvdump/testdata ( https://github.com/performancecopilot/speed/tree/master/mmvdump/testdata )

[[e-mail] Integration]

[hornet:master] New Comment on Pull Request #24 Implement low-level MMV API ( https://github.com/performancecopilot/hornet/pull/24 )
By saurvs ( https://github.com/saurvs ) :

Yes, once the indom branch is merged I'll update the tests.



---

[hornet:master] New Comment on Pull Request #24 Implement low-level MMV API ( https://github.com/performancecopilot/hornet/pull/24 )
By saurvs ( https://github.com/saurvs ) :

Yes, once the indom branch is merged I'll update the tests in client.

[[e-mail] Integration]

2 New Commits:

[hornet:mmvdump] By Saurav Sachidanand <***@gmail.com>:
ff3238cc55f2 ( https://github.com/performancecopilot/hornet/commit/ff3238cc55f2392ce7a37e52d9e3662f63a6db18 ) : Implement mmvdump

Added: src/bin/mmvdump.rs ( https://github.com/performancecopilot/hornet/blob/mmvdump/src/bin/mmvdump.rs )
Added: tests/mmvdump_test.rs ( https://github.com/performancecopilot/hornet/blob/mmvdump/tests/mmvdump_test.rs )
Added: tests/mmvdump_testdata/output1.golden ( https://github.com/performancecopilot/hornet/blob/mmvdump/tests/mmvdump_testdata/output1.golden )
Added: tests/mmvdump_testdata/output2.golden ( https://github.com/performancecopilot/hornet/blob/mmvdump/tests/mmvdump_testdata/output2.golden )
Added: tests/mmvdump_testdata/output3.golden ( https://github.com/performancecopilot/hornet/blob/mmvdump/tests/mmvdump_testdata/output3.golden )
Added: tests/mmvdump_testdata/output4.golden ( https://github.com/performancecopilot/hornet/blob/mmvdump/tests/mmvdump_testdata/output4.golden )
Added: tests/mmvdump_testdata/test1.mmv ( https://github.com/performancecopilot/hornet/blob/mmvdump/tests/mmvdump_testdata/test1.mmv )
Added: tests/mmvdump_testdata/test2.mmv ( https://github.com/performancecopilot/hornet/blob/mmvdump/tests/mmvdump_testdata/test2.mmv )
Added: tests/mmvdump_testdata/test3.mmv ( https://github.com/performancecopilot/hornet/blob/mmvdump/tests/mmvdump_testdata/test3.mmv )
Added: tests/mmvdump_testdata/test4.mmv ( https://github.com/performancecopilot/hornet/blob/mmvdump/tests/mmvdump_testdata/test4.mmv )
Modified: src/mmv.rs ( https://github.com/performancecopilot/hornet/blob/mmvdump/src/mmv.rs )

[hornet:mmvdump] By Saurav Sachidanand <***@gmail.com>:
b5b6eb704d7b ( https://github.com/performancecopilot/hornet/commit/b5b6eb704d7b0fd7cf499d073106ae2177c7784e ) : Merge branch 'mmvdump' of https://github.com/performancecopilot/hornet into mmvdump

Modified: README.md ( https://github.com/performancecopilot/hornet/blob/mmvdump/README.md )



---

[performancecopilot/hornet] Pull request updated by saurvs ( https://github.com/saurvs ) :

#24 Implement low-level MMV API ( https://github.com/performancecopilot/hornet/pull/24 )

This will also be useful for implementing the mmvdump command and for testing MMV writing.



---

[performancecopilot/hornet] Pull request updated by saurvs ( https://github.com/saurvs ) :

#24 Implement low-level MMV API and mmvdump ( https://github.com/performancecopilot/hornet/pull/24 )

This will also be useful for implementing the mmvdump command and for testing MMV writing.



---

[hornet:master] New Comment on Pull Request #24 Implement low-level MMV API and mmvdump ( https://github.com/performancecopilot/hornet/pull/24 )
By saurvs ( https://github.com/saurvs ) :

* [ ] Print string repr for unit
* [ ] Check for invalid indom id

[[e-mail] Integration]

[hornet:master] New Comment on Pull Request #24 Implement low-level MMV API and mmvdump ( https://github.com/performancecopilot/hornet/pull/24 )
By saurvs ( https://github.com/saurvs ) :

* [ ] Print string repr for unit
* [ ] Print string repr for mmv flags
* [ ] Check for invalid indom id
* [ ] Check for invalid item id



---

1 New Commit:

[hornet:mmvdump] By Saurav Sachidanand <***@gmail.com>:
2753a3f9413e ( https://github.com/performancecopilot/hornet/commit/2753a3f9413ee9db727f302b3e644b0db7321b06 ) : Add invalid indom id check

Modified: src/bin/mmvdump.rs ( https://github.com/performancecopilot/hornet/blob/mmvdump/src/bin/mmvdump.rs )
Modified: src/lib.rs ( https://github.com/performancecopilot/hornet/blob/mmvdump/src/lib.rs )
Modified: src/mmv.rs ( https://github.com/performancecopilot/hornet/blob/mmvdump/src/mmv.rs )
Modified: tests/mmvdump_testdata/output1.golden ( https://github.com/performancecopilot/hornet/blob/mmvdump/tests/mmvdump_testdata/output1.golden )
Modified: tests/mmvdump_testdata/output3.golden ( https://github.com/performancecopilot/hornet/blob/mmvdump/tests/mmvdump_testdata/output3.golden )
Modified: tests/mmvdump_testdata/output4.golden ( https://github.com/performancecopilot/hornet/blob/mmvdump/tests/mmvdump_testdata/output4.golden )



---

[performancecopilot/hornet] Pull request updated by saurvs ( https://github.com/saurvs ) :

#24 Implement low-level MMV API and mmvdump ( https://github.com/performancecopilot/hornet/pull/24 )

This will also be useful for implementing the mmvdump command and for testing MMV writing.



---

1 New Commit:

[hornet:mmvdump] By Saurav Sachidanand <***@gmail.com>:
1ab6b783aa7b ( https://github.com/performancecopilot/hornet/commit/1ab6b783aa7b5a13583ab524ee7c3705f159f152 ) : Add invalid item and indom id check

Modified: src/bin/mmvdump.rs ( https://github.com/performancecopilot/hornet/blob/mmvdump/src/bin/mmvdump.rs )
Modified: src/lib.rs ( https://github.com/performancecopilot/hornet/blob/mmvdump/src/lib.rs )
Modified: src/mmv.rs ( https://github.com/performancecopilot/hornet/blob/mmvdump/src/mmv.rs )
Modified: tests/mmvdump_testdata/output1.golden ( https://github.com/performancecopilot/hornet/blob/mmvdump/tests/mmvdump_testdata/output1.golden )
Modified: tests/mmvdump_testdata/output3.golden ( https://github.com/performancecopilot/hornet/blob/mmvdump/tests/mmvdump_testdata/output3.golden )
Modified: tests/mmvdump_testdata/output4.golden ( https://github.com/performancecopilot/hornet/blob/mmvdump/tests/mmvdump_testdata/output4.golden )



---

[performancecopilot/hornet] Pull request updated by saurvs ( https://github.com/saurvs ) :

#24 Implement low-level MMV API and mmvdump ( https://github.com/performancecopilot/hornet/pull/24 )

This will also be useful for implementing the mmvdump command and for testing MMV writing.

[[e-mail] Integration]

[hornet:master] New Comment on Pull Request #24 Implement low-level MMV API and mmvdump ( https://github.com/performancecopilot/hornet/pull/24 )
By saurvs ( https://github.com/saurvs ) :

* [ ] Print string repr for unit
* [ ] Print string repr for mmv flags
* [ ] Check for invalid indom id
* [x] Check for invalid item id



---

[hornet:master] New Comment on Pull Request #24 Implement low-level MMV API and mmvdump ( https://github.com/performancecopilot/hornet/pull/24 )
By saurvs ( https://github.com/saurvs ) :

* [ ] Print string repr for unit
* [ ] Print string repr for mmv flags
* [x] Check for invalid indom id
* [x] Check for invalid item id

[[e-mail] Integration]

[performancecopilot/hornet] Pull request closed by ryandoyle ( https://github.com/ryandoyle ) :

#23 Implement instance metrics with explicit indoms ( https://github.com/performancecopilot/hornet/pull/23 )

This is a slightly more complex API which makes Indom explicit to the user. As opposed to https://github.com/performancecopilot/hornet/pull/20 ( https://github.com/performancecopilot/hornet/pull/20 ) , this API allows setting of the Indom's short and long text, and also allows sharing indoms between instance metrics.

I've also added an Indom cache while writing the MMV to write only one indom block per unique Indom , and a string cache for constant strings as well.



---

1 New Commit:

[hornet:master] By Saurav Sachidanand <***@gmail.com>:
c3c6f95e955e ( https://github.com/performancecopilot/hornet/commit/c3c6f95e955ec6845fa66b238bfdbf870d9136bd ) : Implement instance metrics with explicit indoms (#23) * Implement MMVv1 instance metrics * Make indoms explicit * Add string cache * Write cargo doc comments * Suffix instance to metric names * Change instance implementation * Fix mmv_size bug * Add string length checks for Indom Also uncomment some code

Added: examples/acme.rs ( https://github.com/performancecopilot/hornet/blob/master/examples/acme.rs )
Modified: examples/physical.rs ( https://github.com/performancecopilot/hornet/blob/master/examples/physical.rs )
Modified: src/client/metric.rs ( https://github.com/performancecopilot/hornet/blob/master/src/client/metric.rs )
Modified: src/client/mod.rs ( https://github.com/performancecopilot/hornet/blob/master/src/client/mod.rs )
Modified: src/lib.rs ( https://github.com/performancecopilot/hornet/blob/master/src/lib.rs )



---

[hornet:master] New Comment on Pull Request #23 Implement instance metrics with explicit indoms ( https://github.com/performancecopilot/hornet/pull/23 )
By ryandoyle ( https://github.com/ryandoyle ) :

Hey @saurvs. I've merged this in case it was blocking you. If @cuviper has additional feedback we can add that into another commit/PR.

Cheers!

[[e-mail] Integration]

[hornet:master] New Comment on Pull Request #23 Implement instance metrics with explicit indoms ( https://github.com/performancecopilot/hornet/pull/23 )
By saurvs ( https://github.com/saurvs ) :

Thanks @ryandoyle!



---

2 New Commits:

[hornet:mmvdump] By Saurav Sachidanand <***@gmail.com>:
c3c6f95e955e ( https://github.com/performancecopilot/hornet/commit/c3c6f95e955ec6845fa66b238bfdbf870d9136bd ) : Implement instance metrics with explicit indoms (#23) * Implement MMVv1 instance metrics * Make indoms explicit * Add string cache * Write cargo doc comments * Suffix instance to metric names * Change instance implementation * Fix mmv_size bug * Add string length checks for Indom Also uncomment some code

Added: examples/acme.rs ( https://github.com/performancecopilot/hornet/blob/mmvdump/examples/acme.rs )
Modified: examples/physical.rs ( https://github.com/performancecopilot/hornet/blob/mmvdump/examples/physical.rs )
Modified: src/client/metric.rs ( https://github.com/performancecopilot/hornet/blob/mmvdump/src/client/metric.rs )
Modified: src/client/mod.rs ( https://github.com/performancecopilot/hornet/blob/mmvdump/src/client/mod.rs )
Modified: src/lib.rs ( https://github.com/performancecopilot/hornet/blob/mmvdump/src/lib.rs )

[hornet:mmvdump] By Saurav Sachidanand <***@gmail.com>:
f2753c8c944f ( https://github.com/performancecopilot/hornet/commit/f2753c8c944ffddb819996f0a4c53c22d7721146 ) : Merge branch 'master' into mmvdump

Added: examples/acme.rs ( https://github.com/performancecopilot/hornet/blob/mmvdump/examples/acme.rs )
Modified: examples/physical.rs ( https://github.com/performancecopilot/hornet/blob/mmvdump/examples/physical.rs )
Modified: src/client/metric.rs ( https://github.com/performancecopilot/hornet/blob/mmvdump/src/client/metric.rs )
Modified: src/client/mod.rs ( https://github.com/performancecopilot/hornet/blob/mmvdump/src/client/mod.rs )
Modified: src/lib.rs ( https://github.com/performancecopilot/hornet/blob/mmvdump/src/lib.rs )



---

[performancecopilot/hornet] Pull request updated by saurvs ( https://github.com/saurvs ) :

#24 Implement low-level MMV API and mmvdump ( https://github.com/performancecopilot/hornet/pull/24 )

This will also be useful for implementing the mmvdump command and for testing MMV writing.

[[e-mail] Integration]

5 New Commits:

[hornet:mmvdump] By Saurav Sachidanand <***@gmail.com>:
30bbbbb98c46 ( https://github.com/performancecopilot/hornet/commit/30bbbbb98c467b898ed5cabb3363a71ed31e2c0c ) : Fix cluster ID check

Modified: src/mmv.rs ( https://github.com/performancecopilot/hornet/blob/mmvdump/src/mmv.rs )

[hornet:mmvdump] By Saurav Sachidanand <***@gmail.com>:
661a70cc0296 ( https://github.com/performancecopilot/hornet/commit/661a70cc02967dbc1041b88df97d2d3d31256f3b ) : Refactor offset check logic

Modified: src/mmv.rs ( https://github.com/performancecopilot/hornet/blob/mmvdump/src/mmv.rs )

[hornet:mmvdump] By Saurav Sachidanand <***@gmail.com>:
3c4437cf09e0 ( https://github.com/performancecopilot/hornet/commit/3c4437cf09e0b0f2affff5b8f87a5f0d49a5afa9 ) : Add newline after string section

Modified: src/bin/mmvdump.rs ( https://github.com/performancecopilot/hornet/blob/mmvdump/src/bin/mmvdump.rs )
Modified: tests/mmvdump_testdata/output1.golden ( https://github.com/performancecopilot/hornet/blob/mmvdump/tests/mmvdump_testdata/output1.golden )
Modified: tests/mmvdump_testdata/output2.golden ( https://github.com/performancecopilot/hornet/blob/mmvdump/tests/mmvdump_testdata/output2.golden )
Modified: tests/mmvdump_testdata/output3.golden ( https://github.com/performancecopilot/hornet/blob/mmvdump/tests/mmvdump_testdata/output3.golden )
Modified: tests/mmvdump_testdata/output4.golden ( https://github.com/performancecopilot/hornet/blob/mmvdump/tests/mmvdump_testdata/output4.golden )

[hornet:mmvdump] By Saurav Sachidanand <***@gmail.com>:
0ebf8913cff8 ( https://github.com/performancecopilot/hornet/commit/0ebf8913cff84afc8aea9fee9d388bb2e4dee60b ) : Refactor Semantics print logic

Modified: src/bin/mmvdump.rs ( https://github.com/performancecopilot/hornet/blob/mmvdump/src/bin/mmvdump.rs )
Modified: src/client/metric.rs ( https://github.com/performancecopilot/hornet/blob/mmvdump/src/client/metric.rs )

[hornet:mmvdump] By Saurav Sachidanand <***@gmail.com>:
0088b6338ccc ( https://github.com/performancecopilot/hornet/commit/0088b6338ccc82c17e602f1f18245c598d53e6da ) : Merge branch 'mmvdump' of https://github.com/performancecopilot/hornet into mmvdump

Added: examples/acme.rs ( https://github.com/performancecopilot/hornet/blob/mmvdump/examples/acme.rs )
Modified: examples/physical.rs ( https://github.com/performancecopilot/hornet/blob/mmvdump/examples/physical.rs )
Modified: src/client/metric.rs ( https://github.com/performancecopilot/hornet/blob/mmvdump/src/client/metric.rs )
Modified: src/client/mod.rs ( https://github.com/performancecopilot/hornet/blob/mmvdump/src/client/mod.rs )
Modified: src/lib.rs ( https://github.com/performancecopilot/hornet/blob/mmvdump/src/lib.rs )



---

[performancecopilot/hornet] Pull request updated by saurvs ( https://github.com/saurvs ) :

#24 Implement low-level MMV API and mmvdump ( https://github.com/performancecopilot/hornet/pull/24 )

This will also be useful for implementing the mmvdump command and for testing MMV writing.

[[e-mail] Integration]

3 New Commits:

[hornet:mmvdump] By Saurav Sachidanand <***@gmail.com>:
dd0af6bc445f ( https://github.com/performancecopilot/hornet/commit/dd0af6bc445fabd0e02f0705f61447aa2c4bbb74 ) : Refactor type code and semantic enums

Modified: Cargo.toml ( https://github.com/performancecopilot/hornet/blob/mmvdump/Cargo.toml )
Modified: src/bin/mmvdump.rs ( https://github.com/performancecopilot/hornet/blob/mmvdump/src/bin/mmvdump.rs )
Modified: src/client/metric.rs ( https://github.com/performancecopilot/hornet/blob/mmvdump/src/client/metric.rs )
Modified: src/client/mod.rs ( https://github.com/performancecopilot/hornet/blob/mmvdump/src/client/mod.rs )
Modified: src/lib.rs ( https://github.com/performancecopilot/hornet/blob/mmvdump/src/lib.rs )
Modified: src/mmv.rs ( https://github.com/performancecopilot/hornet/blob/mmvdump/src/mmv.rs )

[hornet:mmvdump] By Saurav Sachidanand <***@gmail.com>:
f7d566b97ebd ( https://github.com/performancecopilot/hornet/commit/f7d566b97ebdad40a7eebdaedb638da6d1712221 ) : Refactor if-let-else logic to match

Modified: src/bin/mmvdump.rs ( https://github.com/performancecopilot/hornet/blob/mmvdump/src/bin/mmvdump.rs )

[hornet:mmvdump] By Saurav Sachidanand <***@gmail.com>:
ae88bc17426f ( https://github.com/performancecopilot/hornet/commit/ae88bc17426fdb276601a954a0834803ede85c4a ) : Add Unit printing

Modified: src/bin/mmvdump.rs ( https://github.com/performancecopilot/hornet/blob/mmvdump/src/bin/mmvdump.rs )
Modified: src/client/metric.rs ( https://github.com/performancecopilot/hornet/blob/mmvdump/src/client/metric.rs )
Modified: tests/mmvdump_testdata/output1.golden ( https://github.com/performancecopilot/hornet/blob/mmvdump/tests/mmvdump_testdata/output1.golden )
Modified: tests/mmvdump_testdata/output2.golden ( https://github.com/performancecopilot/hornet/blob/mmvdump/tests/mmvdump_testdata/output2.golden )
Modified: tests/mmvdump_testdata/output3.golden ( https://github.com/performancecopilot/hornet/blob/mmvdump/tests/mmvdump_testdata/output3.golden )
Modified: tests/mmvdump_testdata/output4.golden ( https://github.com/performancecopilot/hornet/blob/mmvdump/tests/mmvdump_testdata/output4.golden )



---

[performancecopilot/hornet] Pull request updated by saurvs ( https://github.com/saurvs ) :

#24 Implement low-level MMV API and mmvdump ( https://github.com/performancecopilot/hornet/pull/24 )

This will also be useful for implementing the mmvdump command and for testing MMV writing.



---

[hornet:master] New Comment on Pull Request #24 Implement low-level MMV API and mmvdump ( https://github.com/performancecopilot/hornet/pull/24 )
By saurvs ( https://github.com/saurvs ) :

* [x] Print string repr for unit
* [ ] Print string repr for mmv flags
* [x] Check for invalid indom id
* [x] Check for invalid item id

[[e-mail] Integration]

1 New Commit:

[hornet:mmvdump] By Saurav Sachidanand <***@gmail.com>:
22e8a947689f ( https://github.com/performancecopilot/hornet/commit/22e8a947689f11f8efb2c8e3ef49a81f6e9a1526 ) : Make mmv structures generic over readers

Modified: src/mmv.rs ( https://github.com/performancecopilot/hornet/blob/mmvdump/src/mmv.rs )



---

[performancecopilot/hornet] Pull request updated by saurvs ( https://github.com/saurvs ) :

#24 Implement low-level MMV API and mmvdump ( https://github.com/performancecopilot/hornet/pull/24 )

This will also be useful for implementing the mmvdump command and for testing MMV writing.



---

1 New Commit:

[hornet:mmvdump] By Saurav Sachidanand <***@gmail.com>:
d7d42ffce416 ( https://github.com/performancecopilot/hornet/commit/d7d42ffce416db586b85c438cca37b8843d2a115 ) : Remove enum_primitive as it didn't allow enum variant doc comments

Modified: Cargo.toml ( https://github.com/performancecopilot/hornet/blob/mmvdump/Cargo.toml )
Modified: src/bin/mmvdump.rs ( https://github.com/performancecopilot/hornet/blob/mmvdump/src/bin/mmvdump.rs )
Modified: src/client/metric.rs ( https://github.com/performancecopilot/hornet/blob/mmvdump/src/client/metric.rs )
Modified: src/lib.rs ( https://github.com/performancecopilot/hornet/blob/mmvdump/src/lib.rs )
Modified: src/mmv.rs ( https://github.com/performancecopilot/hornet/blob/mmvdump/src/mmv.rs )



---

[performancecopilot/hornet] Pull request updated by saurvs ( https://github.com/saurvs ) :

#24 Implement low-level MMV API and mmvdump ( https://github.com/performancecopilot/hornet/pull/24 )

This will also be useful for implementing the mmvdump command and for testing MMV writing.